feat: parse indicated range to delimit hunks #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zelosleone
commented
Aug 11, 2025
Comment on lines
+3
to
+7
| use super::{Hunk, HunkRange, Line, ESCAPED_CHARS_BYTES, NO_NEWLINE_AT_EOF}; | ||
| use crate::{ | ||
| LineEnd, | ||
| patch::Diff, | ||
| utils::{LineIter, Text}, | ||
| LineEnd, |
There was a problem hiding this comment.
zed auto organized these with rust-analyzer
baszalmstra
approved these changes
Aug 12, 2025
|
I think we should solve the lint issues in another pr, they are just too much |
wolfv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes prefix-dev/rattler-build#1819
issue was actually simpler than i thought. patch is a git-format-patch with 40 patches inside of it as 4 commits. we were not parsing git-metadata with "From" boundary, so we were failing to parse git-format-patches correctly. I also added another test to check if we could parse correctly if we encounter from with diff prefixes, just in case.